mirror of
https://github.com/m8tin/cis.git
synced 2026-06-02 14:56:58 +02:00
Variable assignment checking improved.
This commit is contained in:
+1
-5
@@ -46,13 +46,9 @@ function base.checkScriptforCorrectAssignments() {
|
|||||||
while IFS= read -r _line || [[ -n "${_line}" ]]; do
|
while IFS= read -r _line || [[ -n "${_line}" ]]; do
|
||||||
((_LN++))
|
((_LN++))
|
||||||
|
|
||||||
[[ ! "${_line}" =~ ^.*(=\$|=\"\$).*$ ]] && continue # Assignments only
|
|
||||||
|
|
||||||
[[ "${_line}" =~ ^[[:space:]]*# ]] && continue # Comments are okay
|
[[ "${_line}" =~ ^[[:space:]]*# ]] && continue # Comments are okay
|
||||||
|
|
||||||
[[ "${_line}" =~ ^[[:space:]]+[a-zA-Z0-9_]+=[^\ ]+ ]] && continue # Allow assignments in functions
|
[[ "${_line}" =~ ^[-a-zA-Z0-9_]+=\"?\$\{?([0-9]+|@) ]] && [[ ! "${_line}" =~ "base.set" ]] \
|
||||||
|
|
||||||
[[ "${_line}" =~ ^[a-zA-Z0-9_]+=[^\ ]+ ]] && [[ ! "${_line}" =~ "base.set" ]] \
|
|
||||||
&& echo "❌ line ${_LN}: direct assignment prohibited! Use 'base.set VARNAME VALUE REGEX' instead." >&2 \
|
&& echo "❌ line ${_LN}: direct assignment prohibited! Use 'base.set VARNAME VALUE REGEX' instead." >&2 \
|
||||||
&& _SUCCESS="false"
|
&& _SUCCESS="false"
|
||||||
|
|
||||||
|
|||||||
Reference in New Issue
Block a user